-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-11216][SQL] add encoder/decoder for external row #9184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #43991 has finished for PR 9184 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets put this in its own test suite.
|
This is looking great! Thanks for coming up with a draft so quickly. |
|
Test build #44058 has finished for PR 9184 at commit
|
|
Test build #44061 has finished for PR 9184 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really the right thing to do? I think we are going to NPE execution. If anything I think we'd want to null out all the columns, though I'm not sure we need to handle this case at all.
|
This looks great. I'm going to merge so that I can resolve any conflicts with #9190. We can continue to address comments / TODOs in a follow up PR. |
address comments in #9184 Author: Wenchen Fan <[email protected]> Closes #9212 from cloud-fan/encoder.
address comments in apache/spark#9184 Author: Wenchen Fan <[email protected]> Closes #9212 from cloud-fan/encoder.
Implement encode/decode for external row based on
ClassEncoder.TODO:
fix corner cases