Skip to content

Conversation

@davies
Copy link
Contributor

@davies davies commented Oct 22, 2015

For nested StructType, the underline buffer could be used for others before, we should zero out the padding bytes for those primitive types that have less than 8 bytes.

cc @cloud-fan

@cloud-fan
Copy link
Contributor

LGTM, pending test

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this different from a single

Platform.putLong(holder.buffer, offset, value);

?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm.

Can we add some unit test to test this behavior?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add one tmr.

@SparkQA
Copy link

SparkQA commented Oct 22, 2015

Test build #44132 has finished for PR 9217 at commit 12613bd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * class MutableUnsafeRow(val writer: UnsafeRowWriter) extends GenericMutableRow(null)\n

@rxin
Copy link
Contributor

rxin commented Oct 23, 2015

@davies did you have a chance to add a test case yet?

@SparkQA
Copy link

SparkQA commented Oct 23, 2015

Test build #44204 has finished for PR 9217 at commit cf01d6d.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * class MutableUnsafeRow(val writer: UnsafeRowWriter) extends GenericMutableRow(null)\n

@SparkQA
Copy link

SparkQA commented Oct 23, 2015

Test build #44207 has finished for PR 9217 at commit 9ff3f66.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Oct 23, 2015

Thanks. I've merged this.

@asfgit asfgit closed this in 487d409 Oct 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants