Skip to content

Conversation

@rishabhbhardwaj
Copy link
Contributor

I have made the required changes and tested.
Kindly review the changes.

@mengxr
Copy link
Contributor

mengxr commented Nov 2, 2015

ok to test

@mengxr
Copy link
Contributor

mengxr commented Nov 2, 2015

@yinxusen Could you help review this PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a blank line below here.

@rishabhbhardwaj
Copy link
Contributor Author

@yinxusen Thanks for your comments.Have made the required changes in the files you pointed and others also.Please review.

@SparkQA
Copy link

SparkQA commented Nov 3, 2015

Test build #44872 has finished for PR 9407 at commit a71e99b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

def main(args: Array[String]): Unit = {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line

@yinxusen
Copy link
Contributor

yinxusen commented Nov 3, 2015

@rishabhbhardwaj One more thing, all of your Python code files have no definition of sc. Try to run the example after adding it as a single code file.

@rishabhbhardwaj
Copy link
Contributor Author

@yinxusen Made the changes.Also ran the python files and they are working fine.Thanks for your inputs.WIll keep these points in mind from next time.

@SparkQA
Copy link

SparkQA commented Nov 3, 2015

Test build #44883 has finished for PR 9407 at commit 29a8067.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaGradientBoostingClassificationExample\n * public class JavaGradientBoostingRegressionExample\n * public class JavaRandomForestClassificationExample\n * public class JavaRandomForestRegressionExample\n

@yinxusen
Copy link
Contributor

yinxusen commented Nov 6, 2015

@mengxr LGTM

asfgit pushed a commit that referenced this pull request Nov 13, 2015
… include_example

I have made the required changes and tested.
Kindly review the changes.

Author: Rishabh Bhardwaj <[email protected]>

Closes #9407 from rishabhbhardwaj/SPARK-11445.

(cherry picked from commit 61a2848)
Signed-off-by: Xiangrui Meng <[email protected]>
@mengxr
Copy link
Contributor

mengxr commented Nov 13, 2015

Merged into master and branch-1.6. Thanks!

@asfgit asfgit closed this in 61a2848 Nov 13, 2015
dskrvk pushed a commit to dskrvk/spark that referenced this pull request Nov 13, 2015
… include_example

I have made the required changes and tested.
Kindly review the changes.

Author: Rishabh Bhardwaj <[email protected]>

Closes apache#9407 from rishabhbhardwaj/SPARK-11445.
@rishabhbhardwaj rishabhbhardwaj deleted the SPARK-11445 branch November 28, 2015 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants