Skip to content

[SPARK-11260][SPARKR] with() function support #9443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[SPARK-11260][SPARKR] with() function support #9443

wants to merge 3 commits into from

Conversation

@adrian555
Copy link
Contributor

@adrian555 adrian555 commented Nov 3, 2015

No description provided.

@SparkQA
Copy link

SparkQA commented Nov 3, 2015

Test build #44948 has finished for PR 9443 at commit e9f7fb9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

felixcheung
felixcheung reviewed Nov 4, 2015
View reviewed changes
R/pkg/R/DataFrame.R Outdated
Copy link
Member

@felixcheung felixcheung Nov 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need, S4 wouldn't match if data is missing or not DataFrame

@SparkQA
Copy link

SparkQA commented Nov 4, 2015

Test build #45043 has finished for PR 9443 at commit 691b696.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 5, 2015

Test build #45136 has finished for PR 9443 at commit 449b07b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@felixcheung
Copy link
Member

felixcheung commented Nov 5, 2015

@shivaram

@shivaram
Copy link
Contributor

shivaram commented Nov 5, 2015

LGTM. Thanks @adrian555

asfgit pushed a commit that referenced this pull request Nov 5, 2015
@adrian555 @shivaram
[SPARK-11260][SPARKR] with() function support
975ae4e 
Author: adrian555 <[email protected]>
Author: Adrian Zhuang <[email protected]>

Closes #9443 from adrian555/with.

(cherry picked from commit b9455d1)
Signed-off-by: Shivaram Venkataraman <[email protected]>
@asfgit asfgit closed this in b9455d1 Nov 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adrian555 @SparkQA @felixcheung @shivaram