Skip to content

[SPARK-11654][SQL][follow-up] fix some mistakes and clean up #9688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-11654][SQL][follow-up] fix some mistakes and clean up #9688

wants to merge 1 commit into from

Conversation

@cloud-fan
Copy link
Contributor

@cloud-fan cloud-fan commented Nov 13, 2015

  • rename AppendColumn to AppendColumns to be consistent with the physical plan name.
  • clean up stale comments.
  • always pass in resolved encoder to TypedColumn.withInputType(test added)
  • enable a mistakenly disabled java test.

@cloud-fan
Copy link
Contributor Author

cloud-fan commented Nov 13, 2015

cc @marmbrus

@SparkQA
Copy link

SparkQA commented Nov 13, 2015

Test build #45844 has finished for PR 9688 at commit a16af1f.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaMultilayerPerceptronClassifierExample\n * case class AppendColumns[T, U](\n

@cloud-fan
Copy link
Contributor Author

cloud-fan commented Nov 13, 2015

retest this please.

@SparkQA
Copy link

SparkQA commented Nov 13, 2015

Test build #45864 has finished for PR 9688 at commit a16af1f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * case class AppendColumns[T, U](\n

asfgit pushed a commit that referenced this pull request Nov 13, 2015
@cloud-fan @marmbrus
[SPARK-11654][SQL][FOLLOW-UP] fix some mistakes and clean up
3035e9d 
* rename `AppendColumn` to `AppendColumns` to be consistent with the physical plan name.
* clean up stale comments.
* always pass in resolved encoder to `TypedColumn.withInputType`(test added)
* enable a mistakenly disabled java test.

Author: Wenchen Fan <[email protected]>

Closes #9688 from cloud-fan/follow.

(cherry picked from commit 23b8188)
Signed-off-by: Michael Armbrust <[email protected]>
@asfgit asfgit closed this in 23b8188 Nov 13, 2015
@cloud-fan cloud-fan deleted the follow branch November 14, 2015 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cloud-fan @SparkQA