Skip to content

[SPARK-11738] [SQL] Making ArrayType orderable #9718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

[SPARK-11738] [SQL] Making ArrayType orderable #9718

wants to merge 6 commits into from

Conversation

@yhuai
Copy link
Contributor

@yhuai yhuai commented Nov 15, 2015

yhuai
yhuai reviewed Nov 15, 2015
View reviewed changes
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ordering.scala Outdated
Copy link
Contributor Author

@yhuai yhuai Nov 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines have been moved to compareValue.

@yhuai
Copy link
Contributor Author

yhuai commented Nov 15, 2015

@davies take a look?

@SparkQA
Copy link

SparkQA commented Nov 15, 2015

Test build #45940 has finished for PR 9718 at commit f5f074d.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 15, 2015

Test build #45945 has finished for PR 9718 at commit f43a7f9.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 15, 2015

Test build #45946 has finished for PR 9718 at commit 7228093.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

davies
davies reviewed Nov 15, 2015
View reviewed changes
...atalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala Outdated
Copy link
Contributor

@davies davies Nov 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These could be defined in the loop (let compiler to optimize them easily)

@davies
Copy link
Contributor

davies commented Nov 15, 2015

LGTM, and some minor comments

@SparkQA
Copy link

SparkQA commented Nov 15, 2015

Test build #45955 has finished for PR 9718 at commit aadfeab.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@davies
Copy link
Contributor

davies commented Nov 15, 2015

Merged into master and 1.6 branch, thanks!

asfgit pushed a commit that referenced this pull request Nov 15, 2015
@yhuai @davies
[SPARK-11738] [SQL] Making ArrayType orderable
84f457a 
https://issues.apache.org/jira/browse/SPARK-11738

Author: Yin Huai <[email protected]>

Closes #9718 from yhuai/makingArrayOrderable.
@asfgit asfgit closed this in 3e2e187 Nov 15, 2015
@jinxing64 jinxing64 mentioned this pull request Oct 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yhuai @SparkQA @davies