fix: Migrate charts with empty query_context

[luizotavio32]

SUMMARY

This PR implements a fix for the legacy charts migration. When a chart has a null query_context , a new query_context will be generated using the migrated form_data . Additionally, the query backup will be saved as null in the backup field queries_bak , ensuring that if the chart is downgraded, the query_context will revert to null .

This change was necessary because executing warm_up_cache for a migrated chart with a null query_context results in the error: Chart's query context does not exist. As a consequence, the chart fails to be cached.

TESTING INSTRUCTIONS

Run superset db upgrade and superset db downgrade CLI commands.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[korbit-ai]

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

[codecov]

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.95%. Comparing base (76d897e) to head (4b7463f).
⚠️ Report is 2203 commits behind head on master.

Files with missing lines	Patch %	Lines
superset/migrations/shared/migrate_viz/base.py	0.00%	11 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #33710       +/-   ##
===========================================
+ Coverage   60.48%   72.95%   +12.46%     
===========================================
  Files        1931      558     -1373     
  Lines       76236    40282    -35954     
  Branches     8568     4222     -4346     
===========================================
- Hits        46114    29387    -16727     
+ Misses      28017     9804    -18213     
+ Partials     2105     1091     -1014     

Flag	Coverage Δ
hive	47.21% <0.00%> (-1.94%)	⬇️
javascript	?
mysql	71.94% <0.00%> (?)
postgres	72.00% <0.00%> (?)
presto	50.97% <0.00%> (-2.84%)	⬇️
python	72.91% <0.00%> (+9.41%)	⬆️
sqlite	71.51% <0.00%> (?)
unit	100.00% <ø> (+42.36%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[korbit-ai]

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Status
	Missing Query Builder Implementation ▹ view	🧠 Not in standard

Files scanned

​

File Path	Reviewed
superset/migrations/shared/migrate_viz/base.py	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

[rusackas]

Merge?

[mistercrunch]

Was this a blocker for 5.0? Perhaps the only block RN!?

[michael-s-molina]

Was this a blocker for 5.0? Perhaps the only block RN!?

This was one of the blockers from our side. I'm not sure if it's the only blocker because people didn't vote on RC3 yet 🤷🏼‍♂️