TEZ-4299: Default java opts cause jdk11 to fail #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jteagles: could you please take a look? the patch solves the problem with automatic java version detection btw: I used earlier experience from HIVE-23938 |
|
💔 -1 overall
This message was automatically generated. |
jteagles
reviewed
Apr 2, 2021
| public static final String TEZ_AM_LAUNCH_CMD_OPTS = TEZ_AM_PREFIX + "launch.cmd-opts"; | ||
| public static final String TEZ_AM_LAUNCH_CMD_OPTS_DEFAULT = | ||
| "-XX:+PrintGCDetails -verbose:gc -XX:+PrintGCTimeStamps -XX:+UseNUMA -XX:+UseParallelGC"; | ||
| public static final String TEZ_AM_LAUNCH_CMD_OPTS_JDK9_DEFAULT = |
Contributor
There was a problem hiding this comment.
Could we create TEZ_AM_LAUNCH_CMD_OPTS_JDK8_DEFAULT with the origin value of TEZ_AM_LAUNCH_CMD_OPTS_DEFAULT.
Then we could statically assign TEZ_AM_LAUNCH_CMD_OPTS_DEFAULT to correct value of JDK8 or JDK9+. This would remove the runtime detection.
Contributor
Author
There was a problem hiding this comment.
okay, I'm doing it in the next commit
| } | ||
|
|
||
| private static int getJavaVersion() { | ||
| String javaVersionString = System.getProperty("java.version"); |
Contributor
There was a problem hiding this comment.
I originally detected the presence of java.lang.runtime.Version class to avoid parsing the version string. Knowing the actual version could be more useful in the future though so let's try to keep this for now.
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@jteagles: are you fine with merging this? |
jteagles
approved these changes
Apr 4, 2021
Contributor
jteagles
left a comment
jteagles
left a comment
There was a problem hiding this comment.
+1. Let's put this in master and branch-0.9
asfgit
pushed a commit
that referenced
this pull request
Apr 5, 2021
…reviewed by Jonathan Turner Eagles)
This was referenced May 27, 2024
This was referenced Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.