-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Closed
Labels
Description
Adding some TODOs to track in the TVM CI following #13482 and #13073. The following build configurations were broken:
- Cross-compiling for a platform that could not be executed or linked to via the host platform on linux
- Static-linking libtvm_runtime.so on Windows
We do not currently explicitly test either of these in the CI. We do test cross-compilation via the Hexagon build, but the offending code was disabled for the Hexagon build so this step didn't catch the issue. We could consider:
- Adding an explicit cross-compile of libtvm_runtime.so e.g. to Minimal build or a new build step.
- Adding a static-link build somewhere (not clear if this should be Windows, since that does not block the CI, but people do in practice mostly respect those non-blocking builds, so given it's a use case, we could add it there).
driazati