-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Closed
Closed
Copy link
Labels
needs-triagePRs or issues that need to be investigated by maintainers to find the right assignees to address itPRs or issues that need to be investigated by maintainers to find the right assignees to address ittype: bug
Description
Bug Description: Incorrect Assignment of is_gpu Property
Summary:
In the context of feature extraction using meta_schedule, the is_gpu property was incorrectly assigned by directly comparing the target kind name to "cuda". This approach is not only too specific but also potentially unsafe, as it does not account for different GPU types or handle cases where the target might be undefined.
Incorrect Code:
| bool is_gpu = tune_context->target.value()->kind->name == "cuda"; |
bool is_gpu = tune_context->target.value()->kind->name == "cuda";Problems with the Incorrect Code:
- Lack of Generality: Not all GPUs use CUDA (e.g., AMD GPUs may use ROCm or OpenCL).
- Specificity Issue: Even on NVIDIA hardware, the target kind name isn't guaranteed to be
"cuda"and can vary based on library versions or configurations.
Correct Implementation:
auto& target_keys = tune_context->target.value()->keys;
bool is_gpu = std::find(target_keys.begin(), target_keys.end(), "gpu") != target_keys.end();Explanation of Correct Code:
The corrected code checks if "gpu" exists within the list of keys associated with the target. This method is more robust because:
- It correctly identifies any target that includes
"gpu"in its keys, regardless of the underlying hardware or software platform. - It avoids potential null pointer dereferencing by not directly accessing
kind->name. - It is more flexible and can accommodate various types of GPU targets without hardcoding specific names.
Metadata
Metadata
Assignees
Labels
needs-triagePRs or issues that need to be investigated by maintainers to find the right assignees to address itPRs or issues that need to be investigated by maintainers to find the right assignees to address ittype: bug