[Runtime][PackedFunc] Bring PackedFunc into TVM Object System
#10032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyx-6
requested review from
ZihengJiang,
areusch,
comaniac,
jroesch,
junrushao,
kazum,
kparzysz-quic,
liangfu,
masahi,
tmoreau89,
tqchen and
vinx13
as code owners
junrushao
requested changes
Jan 23, 2022
Member
|
Nice PR @cyx-6! Please also fix the lint and let's get it tested in our CI! |
Co-authored-by: Junru Shao <[email protected]>
Member
|
RFC: apache/tvm-rfcs#51 |
junrushao
reviewed
Feb 2, 2022
Member
|
Thanks @cyx-6 for the huge effort! It's merged!! |
mbs-octoml
pushed a commit
to mbs-octoml/mbs-tvm
that referenced
this pull request
Feb 5, 2022
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows developers to use
PackedFuncas TVM objects, which completes the last missing step of TVM runtime object system.