[TE] Fix Const Int bound analysis to handle uints for division #10102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewZhaoLuo
requested review from
junrushao,
tqchen and
vinx13
as code owners
AndrewZhaoLuo
requested review from
areusch,
comaniac,
icemelon,
jroesch,
merrymercy and
yzhliu
as code owners
tqchen
approved these changes
Jan 29, 2022
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
…e#10102) * case to handle uints * add unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The analyzer tries to see the range an integer variable can represent. Specifically, if the range of a divisor contained zero it would just sort of be ignored (assuming probably that run time checks or otherwise would catch this). This didn't really work for uints though and the analyzer would be sure you were dividing by 0 and be very mad at you
Now
https://discuss.tvm.apache.org/t/failure-occurs-when-using-relay-floor-mod-and-the-divisor-is-of-type-uint64/11994/2