[Torch] Fix conv2d transpose with group #10235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahi
requested review from
Huyuwei,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
kazum,
mbrookhart,
merrymercy,
siju-samuel,
srkreddy1238,
tqchen and
yzhliu
as code owners
Member
|
right. I noticed the same issue very recently. Thanks for fixing this!! |
junrushao
approved these changes
Feb 15, 2022
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
* [Torch] Fix conv2d transpose with group * lint * wrong issue number * do not run test on cuda
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
* [Torch] Fix conv2d transpose with group * lint * wrong issue number * do not run test on cuda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10223
According to https://github.com/pytorch/pytorch/blob/7b8f73dd32a8a893dfb794433ce501e76c53bc89/torch/nn/modules/conv.py#L127-L129,
to correctly decide the output
channelsattribute from the weight shape, we need to multiplyweight_shape[1]by groups.cc @comaniac @junrushao1994