[microNPU] Integrate rolling buffers in Arm(R) Ethos(TM)-U #10344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolaLancellotti
requested review from
Hzfengsy,
MarisaKirisame,
ZihengJiang,
anijain2305,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
kparzysz-quic,
masahi,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
Contributor
Author
NicolaLancellotti
force-pushed
the
ethosu/rolling_buffer
branch
2 times, most recently
from
e59295f to
3050d19
Compare
manupak
reviewed
Feb 25, 2022
Contributor
manupak
left a comment
manupak
left a comment
There was a problem hiding this comment.
Broadly LGTM! (bar a nit)
A review from others are appreciated here!
NicolaLancellotti
force-pushed
the
ethosu/rolling_buffer
branch
2 times, most recently
from
066026b to
9ccc78f
Compare
Contributor
Author
|
The CI problems have been fixed. Other reviews are appreciated. |
ekalda
reviewed
Mar 1, 2022
Contributor
ekalda
left a comment
ekalda
left a comment
There was a problem hiding this comment.
Looks good to me! :) Some questions and suggestions...
python/tvm/relay/backend/contrib/ethosu/tir_to_cs_translator.py
Outdated
Show resolved
Hide resolved
NicolaLancellotti
force-pushed
the
ethosu/rolling_buffer
branch
from
9ccc78f to
8914716
Compare
NicolaLancellotti
force-pushed
the
ethosu/rolling_buffer
branch
from
8914716 to
9576d56
Compare
manupak
requested changes
Mar 18, 2022
Contributor
manupak
left a comment
manupak
left a comment
There was a problem hiding this comment.
@NicolaLancellotti the previous changes still look good.
Just some concerns about the check_rolling_buffer function, otherwise LGTM.
NicolaLancellotti
force-pushed
the
ethosu/rolling_buffer
branch
from
9576d56 to
a2a185b
Compare
Contributor
Author
|
I rebased the first commit and I addressed the comments in the second one. |
manupak
reviewed
Apr 19, 2022
Contributor
manupak
left a comment
manupak
left a comment
There was a problem hiding this comment.
Mostly LGTM bar one request for docs.
Change-Id: Iede5e68981a063f6eb1e118433cc2c92e175af52
NicolaLancellotti
force-pushed
the
ethosu/rolling_buffer
branch
from
a2a185b to
edaab27
Compare
NicolaLancellotti
force-pushed
the
ethosu/rolling_buffer
branch
from
541aa25 to
e319e2b
Compare
Contributor
|
Thanks @NicolaLancellotti @ekalda ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds support for rolling buffers in Arm(R) Ethos(TM)-U.