[CI] hot fix #10464
Merged
[CI] hot fix #10464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hzfengsy
requested review from
comaniac,
icemelon,
jroesch,
junrushao,
tqchen,
yzhliu and
zhiics
as code owners
lhutton1
approved these changes
Mar 3, 2022
Contributor
lhutton1
left a comment
lhutton1
left a comment
There was a problem hiding this comment.
Thanks @Hzfengsy LGTM! perhaps you could try [skip ci] to help get this in quicker? (https://tvm.apache.org/docs/contribute/ci.html#skip-ci-for-reverts)
I'm also wondering why this keeps happening
Contributor
|
Could you point me to an example of CI failing due to 10454? It did flag lint errors in the beginning, but after I fixed them it passed the build. Edit: I found https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-10463/2/pipeline. Interesting, I'm not sure how this happened. |
kparzysz-quic
approved these changes
Mar 3, 2022
Member
|
cc @driazati |
Member
|
Fixed in #10469 |
ziqiangxu8457
pushed a commit
to ziqiangxu8457/tvm
that referenced
this pull request
Mar 6, 2022
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix a CI bug introduced by #10454.
Also, I'm wondering why such PR with lint error can pass the CI?