[TIR] Tuple Reduction Support in CreatePrimFunc #10671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
CC: @Hzfengsy Please review :-) |
Hzfengsy
approved these changes
Mar 22, 2022
* initial * assert structural equal test
MasterJH5574
force-pushed
the
feature/2022-03-17-create-primfunc-tuple-reduction
branch
from
b6453da to
3eb989f
Compare
Member
|
Thanks @hypercubestart @MasterJH5574 for getting the support for tuple reduction in CreatePrimFunc!! |
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
* [CreatePrimFunc] Support multi-source ReduceNode (apache#64) * initial * assert structural equal test * Enhancement and tests * Fix dtype * Docs Co-authored-by: Andrew Liu <[email protected]>
wrongtest-intellif
pushed a commit
that referenced
this pull request
Aug 30, 2022
* [CreatePrimFunc] Support multi-source ReduceNode (#64) * initial * assert structural equal test * Enhancement and tests * Fix dtype * Docs Co-authored-by: Andrew Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support of tuple reduction in
CreatePrimFunc(..).Prior to this PR,
CreatePrimFunc(..)errored out when the inputReduceNodereduces on tuples.With this PR,
CreatePrimFunc(..)generates TIR blocks with correctness guarantees (under the help ofLetStmt) when encountering suchReduceNodes. Please refer to the new unit tests for detailed generated TIR functions :-)cc @hypercubestart @junrushao1994 @Hzfengsy @tqchen
Co-authored-by: Andrew Liu [email protected]