-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[TIR][Analysis] Add SuggestIndexMap for layout rewriting #10732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| """Analysis used in TensorIR scheduling""" | ||
| from typing import List, Optional | ||
|
|
||
| from ..buffer import Buffer | ||
| from ..stmt import For | ||
| from ..expr import PrimExpr | ||
| from ..function import IndexMap | ||
|
|
||
| from . import _ffi_api | ||
|
|
||
|
|
||
| def suggest_index_map( | ||
| buffer: Buffer, | ||
| indices: List[PrimExpr], | ||
| loops: List[For], | ||
| predicate: PrimExpr, | ||
| ) -> Optional[IndexMap]: | ||
| """Provided the access pattern to a buffer, suggest one of the possible layout | ||
| transformation to maximize the locality of the access pattern. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| buffer : Buffer | ||
| The buffer to be transformed. | ||
| indices : List[PrimExpr] | ||
| The access pattern to the buffer. | ||
| loops : List[For] | ||
| The loops above the buffer. | ||
| predicate : PrimExpr | ||
| The predicate of the access. | ||
|
|
||
| Returns | ||
| ------- | ||
| index_map : Optional[IndexMap] | ||
| The suggested index map. None if no transformation is suggested. | ||
| """ | ||
| return _ffi_api.SuggestIndexMap( # type: ignore # pylint: disable=no-member | ||
| buffer, | ||
| indices, | ||
| loops, | ||
| predicate, | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,212 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| #include "../utils.h" | ||
|
|
||
| namespace tvm { | ||
| namespace tir { | ||
|
|
||
| /*! | ||
| * \brief Calculate the strides of the buffer | ||
| * \param buffer The buffer | ||
| * \return The strides | ||
| */ | ||
| Array<PrimExpr> GetStrides(const Buffer& buffer) { | ||
| if (!buffer->strides.empty()) { | ||
| ICHECK_EQ(buffer->strides.size(), buffer->shape.size()); | ||
| return buffer->strides; | ||
| } | ||
| int ndim = buffer->shape.size(); | ||
| if (ndim == 0) { | ||
| return {}; | ||
| } | ||
| Array<PrimExpr> strides(ndim, PrimExpr{nullptr}); | ||
| PrimExpr stride = make_const(buffer->DefaultIndexType(), 1); | ||
| for (int i = ndim - 1; i >= 0; --i) { | ||
| strides.Set(i, stride); | ||
| stride = stride * buffer->shape[i]; | ||
| } | ||
| return strides; | ||
| } | ||
|
|
||
| /*! | ||
| * \brief Auxiliary class that collects the IterSplitExpr in the indexing pattern | ||
| * to help decision making in layout transformation | ||
| */ | ||
| class SplitExprCollector { | ||
| public: | ||
| /*! | ||
| * \brief The corresponding IterSplitExpr, simplified for our case | ||
| * The pattern is `source // lower_factor % extent * scale` | ||
| */ | ||
| struct SplitExpr { | ||
| /*! \brief The source variable */ | ||
| Var source; | ||
| /*! \brief The lower factor of the split expression */ | ||
| int64_t lower_factor; | ||
| /*! \brief The extent of the split expression */ | ||
| int64_t extent; | ||
| }; | ||
|
|
||
| /*! | ||
| * \brief Collect the split expressions in the indexing pattern | ||
| * \param index The indexing pattern | ||
| * \param input_iters The input iterators' domain | ||
| * \param predicate The predicate of the affine map | ||
| * \param require_bijective Whether the affine map is required to be bijective | ||
| * \param analyzer The analyzer | ||
| * \return The collected split expressions | ||
| */ | ||
| static std::vector<SplitExpr> Collect(const PrimExpr& index, | ||
| const Map<Var, Range>& input_iters, // | ||
| const PrimExpr& predicate, // | ||
| bool require_bijective, // | ||
| arith::Analyzer* analyzer) { | ||
| DiagnosticContext diag_ctx(DiagnosticContext::Default(IRModule())); | ||
| Array<arith::IterSumExpr> iter_sum_exprs = arith::DetectIterMap( | ||
| {analyzer->Simplify(index)}, input_iters, predicate, require_bijective, analyzer, diag_ctx); | ||
| if (iter_sum_exprs.empty()) { | ||
| return {}; | ||
| } | ||
| ICHECK_EQ(iter_sum_exprs.size(), 1); | ||
| if (iter_sum_exprs[0]->args.size() == 0) { | ||
| return {}; | ||
| } | ||
| SplitExprCollector collector; | ||
| collector.Visit(iter_sum_exprs[0]); | ||
| if (collector.failed_) { | ||
| return {}; | ||
| } | ||
| return std::move(collector.exprs_); | ||
| } | ||
|
|
||
| private: | ||
| void Visit(const arith::IterSplitExpr& expr) { | ||
| if (const auto* var = expr->source->source.as<tir::VarNode>()) { | ||
| const int64_t* lower_factor = as_const_int(expr->lower_factor); | ||
| const int64_t* extent = as_const_int(expr->extent); | ||
| if (lower_factor == nullptr || extent == nullptr) { | ||
| failed_ = true; | ||
| return; | ||
| } | ||
| exprs_.push_back(SplitExpr{GetRef<Var>(var), *lower_factor, *extent}); | ||
| } else if (const auto* iter_sum_expr = expr->source->source.as<arith::IterSumExprNode>()) { | ||
| Visit(GetRef<arith::IterSumExpr>(iter_sum_expr)); | ||
| } else { | ||
| ICHECK(false) << "Unexpected type: " << expr->source->source->GetTypeKey(); | ||
| } | ||
| } | ||
|
|
||
| void Visit(const arith::IterSumExpr& expr) { | ||
| for (const arith::IterSplitExpr& arg : expr->args) { | ||
| Visit(arg); | ||
| } | ||
| } | ||
|
|
||
| /*! \brief Whether the analysis failed */ | ||
| bool failed_ = false; | ||
| /*! \brief The collected split expressions */ | ||
| std::vector<SplitExpr> exprs_; | ||
| }; | ||
|
|
||
| Optional<IndexMap> SuggestIndexMap(const Buffer& buffer, const Array<PrimExpr>& indices, | ||
| const Array<For>& loops, const PrimExpr& predicate, | ||
| arith::Analyzer* analyzer) { | ||
| int ndim = buffer->shape.size(); | ||
| int n_loops = loops.size(); | ||
| // Step 1. Collect the domains and indices of loop variables | ||
| Map<Var, Range> input_iters; | ||
| std::unordered_map<const VarNode*, int> var2id; | ||
| var2id.reserve(n_loops); | ||
| for (int i = 0; i < n_loops; ++i) { | ||
| const For& loop = loops[i]; | ||
| input_iters.Set(loop->loop_var, Range::FromMinExtent(loop->min, loop->extent)); | ||
| var2id.emplace(loop->loop_var.get(), i); | ||
| } | ||
| // Step 2. Calculate a functor that flattens a multi-dimensional index | ||
| auto f_flatten_index = [ndim, strides = GetStrides(buffer), dtype = buffer->DefaultIndexType()]( | ||
| const Array<PrimExpr>& indices) -> PrimExpr { | ||
| PrimExpr flatten_index = make_const(dtype, 0); | ||
| for (int i = 0; i < ndim; ++i) { | ||
| flatten_index = flatten_index + strides[i] * indices[i]; | ||
| } | ||
| return flatten_index; | ||
| }; | ||
| // Step 3. Detect the IterSplitExpr of the indexing pattern | ||
| std::vector<SplitExprCollector::SplitExpr> split_exprs = SplitExprCollector::Collect( | ||
| /*index=*/f_flatten_index(indices), input_iters, predicate, | ||
| /*require_bijective=*/false, analyzer); | ||
| if (split_exprs.empty()) { | ||
| return NullOpt; | ||
| } | ||
| // Step 4. Sort the order of the split expressions | ||
| std::vector<int> order(split_exprs.size(), 0); | ||
| std::generate(order.begin(), order.end(), [n = 0]() mutable { return n++; }); | ||
| std::sort(order.begin(), order.end(), [&split_exprs, &var2id](int _a, int _b) -> bool { | ||
| const SplitExprCollector::SplitExpr& a = split_exprs[_a]; | ||
| const SplitExprCollector::SplitExpr& b = split_exprs[_b]; | ||
| int a_var_id = var2id.at(a.source.get()); | ||
| int b_var_id = var2id.at(b.source.get()); | ||
| if (a_var_id != b_var_id) { | ||
| return a_var_id < b_var_id; | ||
| } | ||
| return a.lower_factor > b.lower_factor; | ||
| }); | ||
| // Step 5. Create the indexing mapping | ||
| auto f_alter_layout = [f_flatten_index = std::move(f_flatten_index), // | ||
| split_exprs = std::move(split_exprs), // | ||
| order = std::move(order), // | ||
| shape = buffer->shape, // | ||
| analyzer // | ||
| ](Array<Var> indices) -> Array<PrimExpr> { | ||
| ICHECK_EQ(indices.size(), shape.size()); | ||
| for (int i = 0, n = indices.size(); i < n; ++i) { | ||
| analyzer->Bind(indices[i], Range::FromMinExtent(0, shape[i])); | ||
| } | ||
| PrimExpr index = f_flatten_index({indices.begin(), indices.end()}); | ||
| int ndim = split_exprs.size(); | ||
| // Step 5.1. Split the flattened index according to `split_exprs` | ||
| std::vector<PrimExpr> split; | ||
| split.reserve(ndim); | ||
| for (int i = ndim - 1; i >= 0; --i) { | ||
| index = analyzer->Simplify(index); | ||
| int64_t extent = split_exprs[i].extent; | ||
| split.push_back(analyzer->Simplify(floormod(index, extent))); | ||
| index = floordiv(index, extent); | ||
| } | ||
| std::reverse(split.begin(), split.end()); | ||
| // Step 5.2. Reorder the indexing pattern according to `order` | ||
| Array<PrimExpr> results; | ||
| results.reserve(ndim); | ||
| for (int i = 0; i < ndim; ++i) { | ||
| results.push_back(split[order[i]]); | ||
| } | ||
| return results; | ||
| }; | ||
| return IndexMap::FromFunc(ndim, f_alter_layout); | ||
| } | ||
|
|
||
| TVM_REGISTER_GLOBAL("tir.schedule.SuggestIndexMap") | ||
| .set_body_typed([](Buffer buffer, Array<PrimExpr> indices, Array<For> loops, | ||
| PrimExpr predicate) { | ||
| arith::Analyzer analyzer; | ||
| return SuggestIndexMap(buffer, indices, loops, predicate, &analyzer); | ||
| }); | ||
|
|
||
| } // namespace tir | ||
| } // namespace tvm | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found it less convincing to couple frontend features (
DiagnosticContext) with purely arithmetic analysis. we ideally should remove this argument in DetectIterMap @wrongtestThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@junrushao1994 Hi, any suggestion for the dbg info in
DetectIterMap? We may remove them or change to logging if the diag ctx is not preferred.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally speaking,
DiagnosticContextis a frontend feature, while arithmetic analysis is considered as a backend utility, which could be used with or without a particular frontend. Therefore, I would prefer moving error reporting to more frontend places instead of mixing them together in the backend