Skip to content

[Hexagon] Use single allocation to back 2-d arrays #10903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2022
Merged

[Hexagon] Use single allocation to back 2-d arrays #10903

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfccdd2
[Hexagon] Use single allocation to back 2-d arrays
Lunderberg Mar 24, 2022
42e6e85
[Hexagon] Maintain alignment of allocations
Lunderberg Mar 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions src/runtime/hexagon/hexagon/hexagon_buffer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,17 +150,24 @@ HexagonBuffer::HexagonBuffer(size_t nallocs, size_t nbytes, size_t alignment,
Optional<String> scope)
: ndim_(2), nbytes_per_allocation_(nbytes) {
SetStorageScope(scope);

size_t nbytes_aligned = ((nbytes + (alignment - 1)) / alignment) * alignment;
size_t nbytes_monolithic = nallocs * nbytes_aligned;

std::unique_ptr<Allocation> alloca = nullptr;
if (GetStorageScope() == StorageScope::kDDR) {
alloca = Allocator<StorageScope::kDDR>(nbytes_monolithic, alignment);
} else if (GetStorageScope() == StorageScope::kVTCM) {
alloca = Allocator<StorageScope::kVTCM>(nbytes_monolithic, alignment);
}
CHECK(alloca) << "could not create allocation";

for (size_t i = 0; i < nallocs; ++i) {
std::unique_ptr<Allocation> alloca = nullptr;
if (GetStorageScope() == StorageScope::kDDR) {
alloca = Allocator<StorageScope::kDDR>(nbytes, alignment);
} else if (GetStorageScope() == StorageScope::kVTCM) {
alloca = Allocator<StorageScope::kVTCM>(nbytes, alignment);
}
CHECK(alloca != nullptr);
allocations_.push_back(alloca->data_);
managed_allocations_.push_back(std::move(alloca));
void* alloc_offset = static_cast<unsigned char*>(alloca->data_) + i * nbytes_aligned;
allocations_.push_back(alloc_offset);
}

managed_allocations_.push_back(std::move(alloca));
}

HexagonBuffer::HexagonBuffer(void* data, size_t nbytes, Optional<String> scope)
Expand Down