Skip to content

[Hexagon] Cleanup, remove obsolete comment #10931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2022
Merged

[Hexagon] Cleanup, remove obsolete comment #10931

merged 1 commit into from
Apr 8, 2022

Conversation

@Lunderberg
Copy link
Contributor

@Lunderberg Lunderberg commented Apr 7, 2022 •
edited by github-actions bot
Loading

The RPC_SERVER_PORT variable was no longer necessary after #10581.

cc @mehrdadh

@mehrdadh mehrdadh self-assigned this Apr 7, 2022
mehrdadh
mehrdadh approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@mehrdadh mehrdadh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Lunderberg
[Hexagon] Cleanup, remove obsolete comment
04e5a58 
Should have been removed as part of
apache#10581.
@Lunderberg Lunderberg force-pushed the hexagon_launcher_remove_obsolete_comment branch from 1386a2e to 04e5a58 Compare April 8, 2022 13:22
@Lunderberg
Copy link
Contributor Author

Lunderberg commented Apr 8, 2022

CI failed with a segfault in tests/python/frontend/paddlepaddle/test_forward.py::test_forward_math_api, which looks to be unrelated.

Rebased on main to restart CI, to see if it's a flaky test.

@kparzysz-quic kparzysz-quic merged commit bf7a27b into apache:main Apr 8, 2022
@Lunderberg Lunderberg deleted the hexagon_launcher_remove_obsolete_comment branch April 9, 2022 13:19
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Apr 11, 2022
@Lunderberg @mehrdadh
[Hexagon] Cleanup, remove obsolete comment (apache#10931)
941b71a 
Should have been removed as part of
apache#10581.
Lucien0 pushed a commit to Lucien0/tvm that referenced this pull request Apr 19, 2022
@Lunderberg @Lucien0
[Hexagon] Cleanup, remove obsolete comment (apache#10931)
199c3eb 
Should have been removed as part of
apache#10581.
altanh pushed a commit to altanh/tvm that referenced this pull request Apr 28, 2022
@Lunderberg @altanh
[Hexagon] Cleanup, remove obsolete comment (apache#10931)
df6e853 
Should have been removed as part of
apache#10581.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mehrdadh mehrdadh mehrdadh approved these changes

Assignees

@mehrdadh mehrdadh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lunderberg @mehrdadh @kparzysz-quic