Skip to content

[Metaschedule] Make custom schedule_rule registration optional #10975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 13, 2022
Merged

[Metaschedule] Make custom schedule_rule registration optional #10975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
87c3402
allow missing schedule_rule in post order apply
masahi Apr 7, 2022
91b7d6c
update test
masahi Apr 12, 2022
ae87f1a
Skip applying sch_rule when both ann and sch_rule are defined
masahi Apr 12, 2022
a4651db
fixed condition for real
masahi Apr 13, 2022
acf75db
address comment
masahi Apr 13, 2022
55996fe
cpplint
masahi Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions src/meta_schedule/space_generator/post_order_apply.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,19 +136,33 @@ class PostOrderApplyNode : public SpaceGeneratorNode {
stack.emplace_back(sch, blocks);
continue;
}

Optional<String> ann = tir::GetAnn<String>(sch->GetSRef(block_rv), "schedule_rule");
if (ann.defined() == sch_rule.defined() || (ann.defined() && ann.value() == "None")) {
const runtime::PackedFunc* custom_schedule_fn =
ann.defined() ? runtime::Registry::Get(ann.value()) : nullptr;
const bool has_schedule_rule = custom_schedule_fn != nullptr;

if (ann.defined() && !has_schedule_rule) {
LOG(WARNING) << "Custom schedule rule not found, ignoring schedule_rule annotation: "
<< ann.value();
}

if ((has_schedule_rule && sch_rule.defined()) ||
(!has_schedule_rule && !sch_rule.defined()) ||
(ann.defined() && ann.value() == "None")) {
stack.emplace_back(sch, blocks);
continue;
}

Array<tir::Schedule> applied{nullptr};
if (sch_rule.defined()) {
applied = sch_rule.value()->Apply(sch, /*block=*/block_rv);
} else {
const runtime::PackedFunc* f = runtime::Registry::Get(ann.value());
CHECK(f) << "ValueError: Custom schedule rule not found: " << ann.value();
applied = (*f)(sch, block_rv);
ICHECK(custom_schedule_fn)
<< "ValueError: Custom schedule rule not found: " << ann.value();
applied = (*custom_schedule_fn)(sch, block_rv);
}

for (const tir::Schedule& sch : applied) {
stack.emplace_back(sch, blocks);
}
Expand Down
4 changes: 2 additions & 2 deletions tests/python/unittest/test_meta_schedule_post_order_apply.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,8 +371,8 @@ def test_meta_schedule_custom_search_space():
)
post_order_apply = PostOrderApply()
post_order_apply.initialize_with_tune_context(context)
with pytest.raises(ValueError, match="Custom schedule rule not found"):
post_order_apply.generate_design_space(mod)

post_order_apply.generate_design_space(mod)

called = False

Expand Down