[Hexagon] Add test for registered schedules #11016
Conversation
github-actions
bot
requested review from
Lunderberg,
csullivan and
kparzysz-quic
mehrdadh
force-pushed
the
hexagon/add_operator_tests
branch
from
9c1fe0a to
eb69c2f
Compare
mehrdadh
force-pushed
the
hexagon/add_operator_tests
branch
from
eb69c2f to
9d9720f
Compare
csullivan
left a comment
csullivan
left a comment
There was a problem hiding this comment.
This all looks great to me, just a couple comments below for discussion
| """ | ||
| special_stmt - Reads/Writes | ||
| """ | ||
|
|
There was a problem hiding this comment.
This is done by the clang format tool.
| """ | ||
| Scope handler - Loops | ||
| """ | ||
|
|
|
|
||
| // TODO(mehrdadh): make this configurable. | ||
| #define TVM_HEXAGON_RPC_BUFF_SIZE_BYTES 2 * 1024 * 1024 | ||
| #define TVM_HEXAGON_RPC_BUFF_SIZE_BYTES 5 * 1024 * 1024 |
There was a problem hiding this comment.
Looking at the TODO above, should we make this configurable now?
There was a problem hiding this comment.
yeah makes sense. Waiting for #11022 to merge and then will rebase and fix this.
| use_cache=false | ||
| if [ $# -ge 1 ] && [[ "$1" == "--use-cache" ]]; then | ||
| use_cache=true | ||
| shift 1 | ||
| fi | ||
|
|
There was a problem hiding this comment.
Unrelated to this PR but useful change for development. I could send a separate PR if you suggest.
| @@ -0,0 +1,138 @@ | |||
| # Licensed to the Apache Software Foundation (ASF) under one | |||
There was a problem hiding this comment.
Should we move these tests to an topi/ subdirectory? Thinking about how we might want the directory structure. These are generic functionality tests, but soon we'll have tests for some of the same operators which utilize more complex scheduling. It would be nice to have these located in separate directories.
There was a problem hiding this comment.
makes sense. Moved them to sub-directories.
added conv2d tests
Remove unused script
mehrdadh
force-pushed
the
hexagon/add_operator_tests
branch
from
692dcc4 to
214872e
Compare
This shards up the hexagon build since after #11016 it's the longest test step. This also drops the max runtime per stage down to 2 hours from 4 hours to make these kind of increases more obvious in the future. Co-authored-by: driazati <[email protected]>
* add hexagon schedule tests * moved tests to sub-directories
This shards up the hexagon build since after apache#11016 it's the longest test step. This also drops the max runtime per stage down to 2 hours from 4 hours to make these kind of increases more obvious in the future. Co-authored-by: driazati <[email protected]>
2 participants
This PR adds test for registered schedules on hexagon target. Follow up to this PR: #10919
cc @kparzysz-quic @csullivan @Lunderberg