Skip to content

Conversation

@BBuf
Copy link
Contributor

@BBuf BBuf commented Apr 18, 2022

  • upgrade oneflow version to v0.7.0 and fix some bug.
  • add tutorial for oneflow fronted and run success.

image

@BBuf BBuf mentioned this pull request Apr 19, 2022
@BBuf
Copy link
Contributor Author

BBuf commented Apr 19, 2022

Changing the docker script won't immediately change CI environments. We need to go through proper steps to update CI.

Please send the docker script change in a separate PR.

I have solved it in this pr: #11052

@BBuf
Copy link
Contributor Author

BBuf commented Apr 20, 2022

@masahi Hey, there is an error that the flowvision package cannot be found when build docs, but I have pip flowvision in #11052, I don't know why? And the oneflow front-end test also failed, probably because the upgraded image didn't work. It seems that the version of oneflow is still v0.6.0. Do you have any idea? Thanks!

@masahi
Copy link
Member

masahi commented Apr 20, 2022

CI update needs several steps, changing the docker script is only the first one. The next step is to wait until a new nightly image, containing the change from your PR yesterday, is pushed to https://hub.docker.com/r/tlcpackstaging/ci_gpu/tags.

Then, I'll test that image on the branch https://github.com/apache/tvm/tree/ci-docker-staging. After we pass CI tests on that branch, we'll open a PR to main updating https://github.com/apache/tvm/blob/ci-docker-staging/Jenkinsfile. CI update is complete after Jenkinsfile change is merged.

@BBuf
Copy link
Contributor Author

BBuf commented Apr 20, 2022

CI update needs several steps, changing the docker script is only the first one. The next step is to wait until a new nightly image, containing the change from your PR yesterday, is pushed to https://hub.docker.com/r/tlcpackstaging/ci_gpu/tags.

Then, I'll test that image on the branch https://github.com/apache/tvm/tree/ci-docker-staging. After we pass CI tests on that branch, we'll open a PR to main updating https://github.com/apache/tvm/blob/ci-docker-staging/Jenkinsfile. CI update is complete after Jenkinsfile change is merged.

Ok, thank you!

@masahi
Copy link
Member

masahi commented Apr 20, 2022

Running oneflow tests with the new oneflow version resulted in some errors https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/ci-docker-staging/252/pipeline/340

Please take a look

@BBuf
Copy link
Contributor Author

BBuf commented Apr 20, 2022

Running oneflow tests with the new oneflow version resulted in some errors https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/ci-docker-staging/252/pipeline/340

Please take a look

I have now reinstalled the oneflow v0.7.0 cpu version locally and run this ci failed sample 100 times but without any failed in locally, it's strange.

@BBuf
Copy link
Contributor Author

BBuf commented Apr 20, 2022

Running oneflow tests with the new oneflow version resulted in some errors https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/ci-docker-staging/252/pipeline/340

Please take a look

I want to confirm whether https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/ci-docker-staging/252/pipeline/340 is running this pr(#11036), because this pr has changed some bug to adopt oneflow v0.7.0 in

@BBuf
Copy link
Contributor Author

BBuf commented Apr 21, 2022

@masahi
Copy link
Member

masahi commented Apr 22, 2022

@BBuf Please run another job, there is unrelated failure on MaxOS build. Glad that there is no error from running oneflow tutorial.

@BBuf
Copy link
Contributor Author

BBuf commented Apr 22, 2022

@BBuf Please run another job, there is unrelated failure on MaxOS build. Glad that there is no error from running oneflow tutorial.

Ok, thanks!

@masahi
Copy link
Member

masahi commented Apr 22, 2022

Another unrelated failure, please run another job...

@BBuf
Copy link
Contributor Author

BBuf commented Apr 23, 2022

Another unrelated failure, please run another job...

ok

@masahi masahi merged commit bce5758 into apache:main Apr 23, 2022
@masahi
Copy link
Member

masahi commented Apr 23, 2022

@BBuf Merged! finally

@BBuf
Copy link
Contributor Author

BBuf commented Apr 23, 2022

@BBuf Merged! finally

nice, thanks!

shtinsa pushed a commit to Deelvin/tvm that referenced this pull request May 17, 2022
* add relay.f.frontend.fm_oneflow support cnns

* support cuda

* fix mobilenetv2 and reviews

* fix: model without meta info

* support eager and yolo, add test

* fix: license

* add: tutorials

* fix: support new graph

* fix some comments

* refine

* fix concat op convert bug

* refine

* refine

* change cuda to cpu

* fix bug

* fix ci error in tvm

* fix pylint check

* delete useless file

* add skimage package in docker

* fix ci error

* fix bug

* add oneflow fronted test in ci

* merge conflict

* fix tutorial

* try to find error in ci

* revert

* merge conflict

* black oneflow

* Delete from_oneflow.py

* fix bug when upgrade oneflow to 0.7.0

* add tutorials

* add tutorials

* try to fix

* fix bug

* add test

* fix bug

* fix flowvision bug

* Update test_forward.py

* Update test_forward.py

Co-authored-by: hhhfccz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants