Remove support for run-time linked-params from codegen #11144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linking parameters via a runtime lookup function no longer happens after commit b5f1dab (PR#8509): "Tir constants integration into compilation pipeline". Now, in cases where the runtime lookup would have happened in the past, the parameters are embedded into TIR, removing the need for a runtime lookup. There is still plenty of code around that implemented the original runtime lookup. This patch removes the unnecessary leftovers from TVM's codegen.
areusch
approved these changes
May 2, 2022
Contributor
areusch
left a comment
areusch
left a comment
There was a problem hiding this comment.
thanks for the cleanup @kparzysz-quic !
shtinsa
pushed a commit
to Deelvin/tvm
that referenced
this pull request
May 17, 2022
Linking parameters via a runtime lookup function no longer happens after commit b5f1dab (PR#8509): "Tir constants integration into compilation pipeline". Now, in cases where the runtime lookup would have happened in the past, the parameters are embedded into TIR, removing the need for a runtime lookup. There is still plenty of code around that implemented the original runtime lookup. This patch removes the unnecessary leftovers from TVM's codegen.
SebastianBoblest
pushed a commit
to SebastianBoblest/tvm
that referenced
this pull request
May 27, 2022
Linking parameters via a runtime lookup function no longer happens after commit b5f1dab (PR#8509): "Tir constants integration into compilation pipeline". Now, in cases where the runtime lookup would have happened in the past, the parameters are embedded into TIR, removing the need for a runtime lookup. There is still plenty of code around that implemented the original runtime lookup. This patch removes the unnecessary leftovers from TVM's codegen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linking parameters via a runtime lookup function no longer happens after commit
b5f1dabce4(PR#8509): "Tir constants integration into compilation pipeline". Now, in cases where the runtime lookup would have happened in the past, the parameters are embedded into TIR, removing the need for a runtime lookup.There is still plenty of code around that implemented the original runtime lookup. This patch removes the unnecessary leftovers from TVM's codegen.