[Hexagon] Add schedule and test for conv2d_transpose_nchw #11175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehrdadh
requested changes
Apr 29, 2022
Member
mehrdadh
left a comment
mehrdadh
left a comment
There was a problem hiding this comment.
Overall looks good. It needs couple of small changes.
Also, I think you need to register the schedule for hexagon strategy.
| tvm.testing.assert_allclose(c.numpy(), c_np, rtol=1e-5) | ||
|
|
||
|
|
||
| class TestConv2DTranspose_1(BaseConv2DTransposeTests): |
Member
There was a problem hiding this comment.
can you combine these three classes using this patter:
batch, in_channel, ... = tvm.testing.parameters((1, (3, 8), ...)
Member
There was a problem hiding this comment.
also rename the class to TestConv2DTranspose
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion. Have addressed both in the next commit.
Contributor
|
Thanks @farshidsp @mehrdadh, this is merged! |
shtinsa
pushed a commit
to Deelvin/tvm
that referenced
this pull request
May 17, 2022
* Add test for registered scheduales - depthwise_conv2d * added more test to depthwise_conv2 * adding new line at the end of the file * reformatted the file * resolve comments * add schedule and tests for conv2d_transpose_nchw * registering conv2d_transpose strategy and clean up test
SebastianBoblest
pushed a commit
to SebastianBoblest/tvm
that referenced
this pull request
May 27, 2022
* Add test for registered scheduales - depthwise_conv2d * added more test to depthwise_conv2 * adding new line at the end of the file * reformatted the file * resolve comments * add schedule and tests for conv2d_transpose_nchw * registering conv2d_transpose strategy and clean up test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds conv2d_transpose schedule and test on hexagon target. This is needed for Pynet model.
cc @mehrdadh @csullivan