[RPC] Revert "Implemented rpc logging (#10967)" #11227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit aa3bcd9, because it fails on Windows CI as reported in issue apache#11220. PR apache#11223 tries to address it but is is failing in the regular CI with testing issue on Hexagon.
Contributor
|
This is merged in favor of unblocking the CI... |
Contributor
|
sorry for the breakage everyone! we'll fix this and push a new PR. |
shtinsa
pushed a commit
to Deelvin/tvm
that referenced
this pull request
May 17, 2022
This reverts commit aa3bcd9, because it fails on Windows CI as reported in issue apache#11220. PR apache#11223 tries to address it but is is failing in the regular CI with testing issue on Hexagon.
SebastianBoblest
pushed a commit
to SebastianBoblest/tvm
that referenced
this pull request
May 27, 2022
This reverts commit aa3bcd9, because it fails on Windows CI as reported in issue apache#11220. PR apache#11223 tries to address it but is is failing in the regular CI with testing issue on Hexagon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit aa3bcd9, because it fails on Windows CI as reported in issue #11220. PR #11223 tries to address it but is is failing in the regular CI with testing issue on Hexagon.
I think the fix to this one is not something we can just quickly implement, so I'm reverting this to unblock CI. I suggest a new PR can be submitted with a combination of #10967 and #11223 with a working version of this feature that passes Windows CI.
cc @mehrdadh @mkatanbaf @Mousius @u99127 for reviews and quick merge to unblock CI