Skip to content

[Android] Update gradle version and other changes in android apps, CI modification to auto-build Android apps and upload artifacts #11241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
May 25, 2022
Merged

[Android] Update gradle version and other changes in android apps, CI modification to auto-build Android apps and upload artifacts #11241

merged 16 commits into from
May 25, 2022

Conversation

@argrento
Copy link
Contributor

@argrento argrento commented May 8, 2022 •
edited
Loading

@argrento
Copy link
Contributor Author

argrento commented May 8, 2022

CC @TejashShah @Lyken17

@argrento argrento changed the title Update gradle version and other changes in android apps, CI modification for auto-build Android apps [Android] Update gradle version and other changes in android apps, CI modification for auto-build Android apps May 9, 2022
@TejashShah
Copy link

TejashShah commented May 10, 2022

@Lyken17 Please take a look at it.

@TejashShah TejashShah mentioned this pull request May 12, 2022
Closed
KJlaccHoeUM9l
KJlaccHoeUM9l reviewed May 13, 2022
View reviewed changes
tmoreau89
tmoreau89 reviewed May 17, 2022
View reviewed changes
Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @argrento for keeping the android RPC app up to date and functional. Let @KJlaccHoeUM9l if the feedback can be addressed!

KJlaccHoeUM9l
KJlaccHoeUM9l reviewed May 20, 2022
View reviewed changes
@argrento argrento changed the title [Android] Update gradle version and other changes in android apps, CI modification for auto-build Android apps [Android] Update gradle version and other changes in android apps, CI modification to auto-build Android apps and upload artifacts May 21, 2022
tmoreau89
tmoreau89 approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments, LGTM

@tmoreau89
Copy link
Contributor

tmoreau89 commented May 23, 2022

@mehrdadh and @jwfromm wanna take a look?

@Lyken17
Copy link
Contributor

Lyken17 commented May 23, 2022

Confirmed can be built on TVM 0.8 and latest commit d146777 on Mac OSX(OpenJDK 1.8.0_312 + Clang 13) and Ubuntu(OpenJDK 1.8.0 + GCC 9).

The CI scripts LGTM, thanks for @argrento effort! Android demo and rpc are important features!

@masahi masahi merged commit 014208e into apache:main May 25, 2022
@driazati driazati mentioned this pull request Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmoreau89 tmoreau89 tmoreau89 approved these changes

+1 more reviewer

@KJlaccHoeUM9l KJlaccHoeUM9l KJlaccHoeUM9l left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@argrento @TejashShah @tmoreau89 @Lyken17 @KJlaccHoeUM9l @masahi