Skip to content

Conversation

@petuca
Copy link
Contributor

@petuca petuca commented Jun 17, 2022

In this PR problem of MXNet dot for all tensor dimensions is fixed. This PR is related to #11691 issue.
Previously, it was only provided the case of 2D tensors, but not 1D and non 2D tensors and their combinations.
This is provided now.

@petuca
Copy link
Contributor Author

petuca commented Jun 23, 2022

Any feedback about this PR?
I know you have more important work to do and that's why this is waiting.

cc: @masahi @junrushao1994 @kevinthesun

@petuca
Copy link
Contributor Author

petuca commented Sep 21, 2022

I think this PR is correct now. The problem was trivial about the structure of the code that lint tests suggested. Please, take a look now if you can.

cc: @masahi @kevinthesun @junrushao

@areusch areusch added needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it and removed needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it labels Oct 19, 2022
@petuca
Copy link
Contributor Author

petuca commented Dec 29, 2022

I rebased and all checks are good now again.

@areusch @masahi

@masahi masahi merged commit 4021eec into apache:main Jan 1, 2023
fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this pull request Mar 27, 2023
* [fix] MXNet dot for all tensor dimensions

* Fixing the MxNet structure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants