[TIR] Make conversion from Integer to int64_t explicit #12010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lunderberg
approved these changes
Jul 5, 2022
Contributor
Lunderberg
left a comment
Lunderberg
left a comment
There was a problem hiding this comment.
I like it, and thank you for tracking down all these instances! I agree with the reasoning in your comment from Friday, that having automatic conversions in both directions between primitives and PrimExpr is causing the issues, and that the automatic primitive to PrimExpr conversion is the more important one to have.
blackkker
pushed a commit
to blackkker/tvm
that referenced
this pull request
Jul 7, 2022
* [TIR] Make conversion from Integer to int64_t explicit * Fix compilation errors * Fix compilation issues in cpptest * Fix SPIRV compilation errors
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Jul 15, 2022
* [TIR] Make conversion from Integer to int64_t explicit * Fix compilation errors * Fix compilation issues in cpptest * Fix SPIRV compilation errors
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
* [TIR] Make conversion from Integer to int64_t explicit * Fix compilation errors * Fix compilation issues in cpptest * Fix SPIRV compilation errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-PR for #11973.