[TVMScript] Printer VarTable #12336
[TVMScript] Printer VarTable #12336
Conversation
yelite
force-pushed
the
tunip-irdocisifer-vartable
branch
6 times, most recently
from
6f46407 to
92c6499
Compare
yelite
force-pushed
the
tunip-irdocisifer-vartable
branch
from
92c6499 to
571c88c
Compare
Co-authored-by: Junru Shao <[email protected]> Co-authored-by: Greg Bonik <[email protected]>
yelite
force-pushed
the
tunip-irdocisifer-vartable
branch
from
571c88c to
4a33a98
Compare
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
Overall LGTM. Just a quick question I'm curious about
| * than IdDoc. It's useful when a variable is implicitly defined without a name, like | ||
| * the buf->data in TIR, which should be mapped to `AttrDoc(IdDoc("<buffer_name>"), "data")`. | ||
| * | ||
| * This function takes a DocFactory instead of Doc. It's because GetVarDoc needs to |
There was a problem hiding this comment.
To make sure I fully comprehend, would you mind elaborating a little bit with a short example? Thanks a lot!
There was a problem hiding this comment.
Sure. Assume DefineByDoc accepts a Doc instead of std::function<Doc()>. It will be more difficult to handle case like
c[k] = a[i] + a[j]
when we call the GetVarDoc for the first a and second a, we expect the returned Docs to be different objects and have different source_path. Therefore the VarTable needs to hold a function that returns Doc, rather than Doc itself.
I also update the doc, trying to better clarify it. Let me know if it still looks confusing.
There was a problem hiding this comment.
That makes sense to me! Thanks for your detailed explanation!
This PR: - Adds IRDocsifier This PR is in draft state because it's branched off from a pending PR #12336 Tracking issue: #11912 Co-authored-by: Greg Bonik <[email protected]>
This PR: - Adds VarTable for the new TVMScript Printer Compared to the prototype version, this: - Removes unnecessary public methods. - GetObjectName - GetUniqueName - Add Frame parameter for `Define` methods. VarTable will add callback to Frame to remove variable when Frame exits. - Changes DocFactory from `ExprDoc(ObjectPath)` to `ExprDoc()` to simplify var definition. Tracking issue: apache#11912
This PR: - Adds IRDocsifier This PR is in draft state because it's branched off from a pending PR apache#12336 Tracking issue: apache#11912 Co-authored-by: Greg Bonik <[email protected]>
2 participants
This PR:
Compared to the prototype version, this:
Definemethods. VarTable will add callback to Frame to remove variable when Frame exits.ExprDoc(ObjectPath)toExprDoc()to simplify var definition.Tracking issue: #11912
cc @junrushao1994 @gbonik