[MetaSchedule][UX] Convenient Object Creation #12643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junrushao
force-pushed
the
feature/2022-08-29/easy-create-objs
branch
from
54d0851 to
6d30617
Compare
Member
Author
junrushao
force-pushed
the
feature/2022-08-29/easy-create-objs
branch
from
6d30617 to
c3df66e
Compare
MasterJH5574
approved these changes
Sep 2, 2022
Contributor
MasterJH5574
left a comment
MasterJH5574
left a comment
There was a problem hiding this comment.
Looks pretty to me! Thanks @junrushao for bringing the convenience!
Hzfengsy
approved these changes
Sep 2, 2022
This PR introduces a set of `.create` methods making it easier to create
MetaSchedule objects.
For example:
```python
ms.database.JSONDatabase(...)
ms.database.create("json")
ms.runner.RPCRunner(...)
ms.runner.create("rpc")
```
Besides, this PR allows `JSONDatabase` to be created via `work_dir`:
```python
db = ms.database.create("json", work_dir="/path/to/db/")
db = ms.database.create(work_dir="/path/to/db/") # or even simpler
```
junrushao
force-pushed
the
feature/2022-08-29/easy-create-objs
branch
from
c3df66e to
6aa8638
Compare
9 tasks
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
This PR introduces a set of `.create` methods making it easier to create
MetaSchedule objects.
For example:
```python
ms.database.JSONDatabase(...)
ms.database.create("json")
ms.runner.RPCRunner(...)
ms.runner.create("rpc")
```
Besides, this PR allows `JSONDatabase` to be created via `work_dir`:
```python
db = ms.database.create("json", work_dir="/path/to/db/")
db = ms.database.create(work_dir="/path/to/db/") # or even simpler
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a set of
.createmethods making it easier to createMetaSchedule objects.
For example:
Besides, this PR allows
JSONDatabaseto be created viawork_dir:cc @Hzfengsy @junrushao1994