[TVMScript] Fix parse minimal i32 literal for tir script #12772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrongtest-intellif
force-pushed
the
fix_minimal_i32_literal
branch
from
9780bd8 to
a693e1f
Compare
wrongtest-intellif
force-pushed
the
fix_minimal_i32_literal
branch
from
a693e1f to
89030e8
Compare
junrushao
approved these changes
Sep 15, 2022
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
Thanks for spotting this corner case!
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
This change tries to fix an issue due to apache#12515. Previously the logic for `-2147483648` is `parse(-literal)` = `-parse(literal)`, and all integer literals are converted to i32 (either the literal value actually overflow or not). Since after apache#12515, parse `2147483648` results in an i64 typed integer rather than i32, `-2147483648` then becomes an i64 integer too, which is not reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there~ the change try fix an issue due to #12515.
Previously the logic for
-2147483648isparse(-literal)=-parse(literal), and all integer literals are converted to i32 (either the literal value actually overflow or not).Since after #12515, parse
2147483648results to an i64 typed integer rather than i32,-2147483648then becomes to one i64 integer too, which is not reasonable.