[MetaSchedule] Enable Clone Function for Task-Level Classes #12796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junrushao
reviewed
Sep 15, 2022
Member
|
Could you please explain a bit about why we need Cloning a function or a module makes sense to me. But I'm not sure why we need to clone a rule or a mutator. Could you please also add more information to the PR description? Thanks |
Member
|
This is used for enhancing UX of the tuning. Considering the current tvm/tests/python/integration/test_meta_schedule_auto_tensorize.py Lines 174 to 175 in 370abe6 where users have to provide a lambda function, has become a bit confusing and inconvenient, we want to make it possible for users to directly provide a single object, and our system takes care of cloning |
junrushao
approved these changes
Sep 16, 2022
Member
junrushao
left a comment
junrushao
left a comment
There was a problem hiding this comment.
Overall LGTM! BTW, please address my comments in a separate PR
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…2796) This PR introduces a clone function for each of the task-level MetaSchedule classes for convenient class deep copying. - [x] ScheduleRule - [x] Postproc - [x] Mutator - [x] SpaceGenerator - [x] SearchStrategy - [x] TuneContext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a clone function for each of the task-level MetaSchedule classes for convenient class deep copying.
Th reason we want to introduce the clone function is for convenient generation of tasks, i.e., instead of creating a class generation lambda function in tuning api we can supply some example classes, i.e.,
ScheduleRuleand clone them. In most cases the tasks share the same type of the classes except IRModule, yet we allow customization of the classes.cc @Hzfengsy @junrushao1994