Skip to content

Conversation

@joshherr-quic
Copy link
Contributor

Updated sha to deal with some codegen issues that came up with the last version.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Nov 17, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@mehrdadh
Copy link
Member

@joshherr-quic thanks for the PR! Could you please build the docker locally and run hexagon tests with the simulator?

@mehrdadh mehrdadh self-assigned this Nov 17, 2022
@joshherr-quic
Copy link
Contributor Author

joshherr-quic commented Nov 17, 2022

@joshherr-quic thanks for the PR! Could you please build the docker locally and run hexagon tests with the simulator?

Will do. Is there a wiki with some quick instructions on how to do this?

Edit: Figured it out

@ibsidorenko
Copy link
Contributor

Hi, @mehrdadh and @joshherr-quic !
Sorry for stupid question, but when I try to use Hexagon docker I run the following command:
./docker/bash.sh ci_hexagon
But as I see from the downloaded image it still uses LLVM-14:

$ /opt/clang-llvm/bin/llvm-config --version
14.0.0

But even LLVM_SHA=361a27c155ec8b should correspond to LLVM-15.x if I am correct.

What should I do to use up-to-date LLVM version in the docker image? Build the docker locally?

@joshherr-quic
Copy link
Contributor Author

joshherr-quic commented Nov 18, 2022

Hi, @mehrdadh and @joshherr-quic ! Sorry for stupid question, but when I try to use Hexagon docker I run the following command: ./docker/bash.sh ci_hexagon But as I see from the downloaded image it still uses LLVM-14:

$ /opt/clang-llvm/bin/llvm-config --version
14.0.0

But even LLVM_SHA=361a27c155ec8b should correspond to LLVM-15.x if I am correct.

What should I do to use up-to-date LLVM version in the docker image? Build the docker locally?

The docker image you download is built according to the tvm commit that corresponds to this commit id. That commit still has llvm 14. The PR that we're looking at merely updates the docker image that would get built locally. We still need to open another PR to update the commit id in the Jenkinsfile so that CI will build the new LLVM version. Only after that follow-up commit will the updated docker with the newer llvm be available.

So your intuition is correct! You would need to build the docker locally to take advantage of the newest LLVM right now. New dockers with new llvm should hopefully be available over the weekend for download.

driazati
driazati previously approved these changes Nov 18, 2022
Copy link
Member

@mehrdadh mehrdadh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for passing test confirmation

@driazati driazati dismissed their stale review November 18, 2022 18:32

Hexagon tests need to be run first

@mehrdadh
Copy link
Member

mehrdadh commented Nov 18, 2022

@ibsidorenko so after @joshherr-quic confirms the tests are passing, we will merge this PR and update the docker image. In the meantime if you need to use docker with updated LLVM, you need to build it locally. We also have automated nightly image build which is published here: https://hub.docker.com/r/tlcpackstaging/ci_hexagon/tags. These docker images are built based on the most recent commit, so the last one should have updated LLVM
These images are not necessarily usable because some of them are failing on some tests

@joshherr-quic
Copy link
Contributor Author

I'm seeing a lot of "AttributeError: 'HexagonLauncherSimulator' object has no attribute '_se" errors, but nothing related to codegen...

@mehrdadh
Copy link
Member

@joshherr-quic where do you see those errors? can you post them here?

@mehrdadh
Copy link
Member

@joshherr-quic any update on this?
Unfortunately This is blocking updating hexagon image. I appreciate if you could provide a follow up on this. thanks!

@mehrdadh
Copy link
Member

cc @kparzysz-quic

@kparzysz-quic kparzysz-quic force-pushed the joshherr/docker-hexagon branch from c70eb4b to 8ce173e Compare January 24, 2023 22:31
@kparzysz-quic
Copy link
Contributor

kparzysz-quic commented Jan 27, 2023

The CI tests have passed with a docker image built from this.

@mehrdadh mehrdadh merged commit 95fa223 into apache:main Jan 27, 2023
fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this pull request Mar 27, 2023
Updated sha to deal with some codegen issues that came up with the last version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants