-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Hexagon][CI] Updated sha for builder LLVM #13418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
|
@joshherr-quic thanks for the PR! Could you please build the docker locally and run hexagon tests with the simulator? |
Will do. Is there a wiki with some quick instructions on how to do this? Edit: Figured it out |
|
Hi, @mehrdadh and @joshherr-quic ! But even LLVM_SHA=361a27c155ec8b should correspond to LLVM-15.x if I am correct. What should I do to use up-to-date LLVM version in the docker image? Build the docker locally? |
The docker image you download is built according to the tvm commit that corresponds to this commit id. That commit still has llvm 14. The PR that we're looking at merely updates the docker image that would get built locally. We still need to open another PR to update the commit id in the Jenkinsfile so that CI will build the new LLVM version. Only after that follow-up commit will the updated docker with the newer llvm be available. So your intuition is correct! You would need to build the docker locally to take advantage of the newest LLVM right now. New dockers with new llvm should hopefully be available over the weekend for download. |
mehrdadh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waiting for passing test confirmation
|
@ibsidorenko so after @joshherr-quic confirms the tests are passing, we will merge this PR and update the docker image. In the meantime if you need to use docker with updated LLVM, you need to build it locally. We also have automated nightly image build which is published here: https://hub.docker.com/r/tlcpackstaging/ci_hexagon/tags. These docker images are built based on the most recent commit, so the last one should have updated LLVM |
|
I'm seeing a lot of "AttributeError: 'HexagonLauncherSimulator' object has no attribute '_se" errors, but nothing related to codegen... |
|
@joshherr-quic where do you see those errors? can you post them here? |
|
@joshherr-quic any update on this? |
c70eb4b to
8ce173e
Compare
|
The CI tests have passed with a docker image built from this. |
Updated sha to deal with some codegen issues that came up with the last version.
Updated sha to deal with some codegen issues that came up with the last version.