Skip to content

Conversation

@Mousius
Copy link
Member

@Mousius Mousius commented Jan 6, 2023

This ensures that if you want to run a specific test script then at least it's reasonably consistent and as people copy test files they'll use the new function 😸

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jan 6, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: tests See #10317 for details

Generated by tvm-bot

@Mousius
Copy link
Member Author

Mousius commented Jan 6, 2023

As promised @mehrdadh 😸 I'm fairly sure this is going to fail with some undefined tvm. Out of interest do we know why we don't encourage people running tests directly using the pytest CLI?

This ensures that if you want to run a specific test script then at least it's reasonably consistent and as people copy test files they'll use the new function 😸
@Mousius Mousius marked this pull request as ready for review January 6, 2023 23:14
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@junrushao junrushao merged commit bd37515 into apache:main Jan 7, 2023
@mehrdadh
Copy link
Member

mehrdadh commented Jan 9, 2023

@Mousius I'm not sure what's the reason behind it. @driazati could help here.
Thanks for sending the fix!

@driazati
Copy link
Member

driazati commented Jan 9, 2023

I’ve always used pytest directly (and that’s what is tested in CI), I don’t think it really makes a huge difference but it’s nice to have the test files be directly runnable

fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this pull request Mar 27, 2023
This ensures that if you want to run a specific test script then at least it's reasonably consistent and as people copy test files they'll use the new function 😸
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants