Skip to content

Conversation

@mehrdadh
Copy link
Member

This PR fixes the SDK installation and separates SDK installation from ZephyrProject installation.
Also it separates the Zephyr python environment to 3.8 which is the required version and it is different than tvm virtual env.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jan 23, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@mehrdadh mehrdadh force-pushed the micro/docker_fix_zephyr_sdk branch from 6c6be5f to e363f1e Compare January 23, 2023 22:25
@mehrdadh mehrdadh requested a review from areusch January 23, 2023 22:26
@mehrdadh mehrdadh force-pushed the micro/docker_fix_zephyr_sdk branch from e363f1e to f1afce4 Compare January 23, 2023 22:52
@mehrdadh mehrdadh force-pushed the micro/docker_fix_zephyr_sdk branch from f1afce4 to e5548cd Compare January 23, 2023 23:59
RUN bash /install/ubuntu_install_zephyr.sh
ENV ZEPHYR_BASE=/opt/zephyrproject/zephyr

#Zephyr SDK
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#Zephyr SDK
# Zephyr SDK


# the requirements above overwrite junintparser with an older version, but it is not
# used so overwrite it again with the correct version
pip3 install junitparser==2.4.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this just using the system Python with python_cmd here? This should still re-install junitparser since that was a hack to get a specific version working in CI which didn't agree with zephyr's requirements

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i might have removed pip3 to stop ppl from installing stuff outside the tvm venv

Copy link
Contributor

@areusch areusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but will allow @driazati to approve


# the requirements above overwrite junintparser with an older version, but it is not
# used so overwrite it again with the correct version
pip3 install junitparser==2.4.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i might have removed pip3 to stop ppl from installing stuff outside the tvm venv

@mehrdadh mehrdadh merged commit fd3f803 into apache:main Jan 24, 2023
@mehrdadh mehrdadh deleted the micro/docker_fix_zephyr_sdk branch January 24, 2023 23:29
fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this pull request Mar 27, 2023
…hyr python environment (apache#13829)

This PR fixes the SDK installation and separates SDK installation from ZephyrProject installation.
Also it separates the Zephyr python environment to 3.8 which is the required version and it is different than tvm virtual env.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants