Enhance the --help message of composite target #13842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Presently --help for vitis displays the target and option string, it has no description. Eg: target vitis-ai dpu<class 'str'> This can be made more meaningful by fetching the description from the config node of the target. Eg: Vitis AI DPU identifier Here, adding test cases to verify the fix Signed-off-by: MNGanesan <[email protected]>
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
lhutton1
reviewed
Jan 25, 2023
Signed-off-by: MNGanesan <[email protected]>
lhutton1
approved these changes
Jan 25, 2023
Contributor
lhutton1
left a comment
lhutton1
left a comment
There was a problem hiding this comment.
Thanks for the contribution @MNGanesan :)
Contributor
Author
|
Thanks Luke!
On Wednesday, 25 January 2023 at 19:19:27 GMT+5:30, Luke Hutton ***@***.***> wrote:
@lhutton1 approved this pull request.
Thanks for the contribution @MNGanesan :)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
fzi-peccia
pushed a commit
to fzi-peccia/tvm
that referenced
this pull request
Mar 27, 2023
Presently --help for vitis displays the target and option string, it has no description. Eg: target vitis-ai dpu<class 'str'> This can be made more meaningful by fetching the description from the config node of the target. Eg: Vitis AI DPU identifier Signed-off-by: MNGanesan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently --help for vitis displays the target and option string,
it has no description. Eg: target vitis-ai dpu<class 'str'>
This can be made more meaningful by fetching the description from the config node of the target. Eg: Vitis AI DPU identifier
Here, adding test cases to verify the fix
Signed-off-by: MNGanesan [email protected]