Skip to content

Conversation

@srkreddy1238
Copy link
Contributor

Unified single documentation for all types of usage with OpenCL as well as CLML backends.

Detailed simplified usage (with docker environment and command line tools like tvmc) as well as advanced usage instructions via python based interface.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jan 30, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@srkreddy1238 srkreddy1238 force-pushed the adreno_documentation branch 4 times, most recently from c14b573 to 772ce6f Compare January 31, 2023 16:06
@srkreddy1238 srkreddy1238 requested a review from echuraev January 31, 2023 16:07
Unified single documentation for all types of usage with OpenCL as well as
CLML backends.

Detailed simplified usage (with docker environment and command line tools like tvmc)
as well as advanced usage instructions via python based interface.
@srkreddy1238 srkreddy1238 force-pushed the adreno_documentation branch 2 times, most recently from 3502ccf to a43658d Compare February 2, 2023 05:26
Copy link
Contributor

@echuraev echuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several comments

@srkreddy1238 srkreddy1238 force-pushed the adreno_documentation branch 3 times, most recently from 4c24470 to 2cdf5fe Compare February 14, 2023 06:15
@srkreddy1238 srkreddy1238 force-pushed the adreno_documentation branch 2 times, most recently from 49b4bbb to caec976 Compare February 14, 2023 14:12
@srkreddy1238 srkreddy1238 force-pushed the adreno_documentation branch from 5b9b1f2 to f6e9a4d Compare March 6, 2023 15:53
Copy link
Contributor

@echuraev echuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several minor comments

"app")
def_environment
echo "Setting dev environment with Tracker Port : $TVM_TRACKER_HOST} and the available devices are"
python3 -m tvm.exec.query_rpc_tracker --port ${TVM_TRACKER_PORT}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understood, the app mode is only for printing the list of the available devices (just call query), am I right?
Probably we should rename this mode to query? And you didn't describe this mode in the documentation. Could you please add it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its sets the pytest and python environments.

@srkreddy1238 srkreddy1238 force-pushed the adreno_documentation branch from 340caef to 908d8e0 Compare March 14, 2023 10:49
Copy link
Contributor

@echuraev echuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @srkreddy1238 for hard working on this PR. The final result looks incredible. Hope it will be very helpful for new users.

@echuraev echuraev merged commit 6eb4b87 into apache:main Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants