Skip to content

Conversation

@echuraev
Copy link
Contributor

The issue was in the shapes mismatch when layout=NHWC was passed to importer. In this case kernel layout in conv2d_transpose operation was set to HWIO but in params HWOI layout was used. And we got the following error:

`Tensor[(2, 2, 64, 128), float32]` does not match `Tensor[(2, 2, 128, 64), float32]`

The issue was in the shapes mismatch when `layout=NHWC` was passed to
importer. In this case kernel layout in conv2d_transpose operation was
set to HWIO but in params HWOI layout was used. And we got the
following error:
```
`Tensor[(2, 2, 64, 128), float32]` does not match `Tensor[(2, 2, 128, 64), float32]`
```
@tvm-bot
Copy link
Collaborator

tvm-bot commented Feb 15, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: keras See #10317 for details

Generated by tvm-bot

Copy link
Contributor

@vvchernov vvchernov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@echuraev echuraev force-pushed the echuraev/fix_keras_conv2d_transpose_nhwc branch from 4fa21a5 to fa81212 Compare February 15, 2023 10:19
Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @echuraev!

@leandron leandron merged commit affcc11 into apache:main Feb 15, 2023
@echuraev echuraev deleted the echuraev/fix_keras_conv2d_transpose_nhwc branch April 14, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants