Skip to content

Conversation

@masahi
Copy link
Member

@masahi masahi commented Mar 14, 2023

The last time we updated the CUDA version on CI was two years ago, I think it is a good time for another update.

v11.7 is the latest version officially supported by PyTorch (https://pytorch.org/get-started/locally/). Rather than jumping directly to v12, I think it is better to stay in the stable v11 line for now.

This would unblock the PR #14291 which uses a relatively new feature in cuBLAS introduced in v11.4.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Mar 14, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@leandron
Copy link
Contributor

My experience with CUDA and the whole CUDA ecosystem is very limited, but just wanted to point out that it would be good to review also the tlcpack CUDA versions, perhaps to propose this new one and deprecate some of the old version. Can you have a look?

@masahi
Copy link
Member Author

masahi commented Mar 14, 2023

Do you mean this https://github.com/tlc-pack/tlcpack? I'm not familiar with this package, but its README shows how to build an image with a specific CUDA version. Is there other action required to support newer CUDA versions in tlcpack?

Copy link
Member

@driazati driazati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tlc-pack/tlcpack repo is separate and doesn't currently have a good strategy to verify changes, so I don't think we should block this PR on that. The updates there on the Docker images used to build packages can happen as a follow up

@masahi
Copy link
Member Author

masahi commented Mar 16, 2023

@driazati It seems the driver hasn't been updated, can you help?

@driazati
Copy link
Member

The GPU nodes should be using the new image now that https://github.com/tlc-pack/ci/actions/runs/4440725353 is done, though it may take some time (i.e. a day or so) to flush out the old, currently running nodes. If you check the task_show_node_info.sh step the new AMI is ami-0dc31952ab98c5d51.

@masahi
Copy link
Member Author

masahi commented Mar 17, 2023

It passed!

@masahi masahi merged commit 58dce66 into apache:main Mar 17, 2023
junrushao pushed a commit that referenced this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants