Skip to content

[TIR] Improved error message in InjectSoftwarePipeline #14391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2023
Merged

[TIR] Improved error message in InjectSoftwarePipeline #14391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/tir/transforms/inject_software_pipeline.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -989,7 +989,8 @@ void BuildDependencyGraph(
class PipelineInjector : private StmtExprMutator {
public:
static Stmt Inject(const PrimFunc& func) {
PipelineInjector injector;
auto global_symbol = func->GetAttr<String>(tvm::attr::kGlobalSymbol);
PipelineInjector injector(global_symbol);
for (const auto& kv : func->buffer_map) {
const Buffer& buffer = kv.second;
injector.buffer_data_to_buffer_.Set(buffer->data, buffer);
Expand All @@ -999,7 +1000,7 @@ class PipelineInjector : private StmtExprMutator {
}

private:
PipelineInjector() {}
explicit PipelineInjector(Optional<String> global_symbol) : global_symbol_(global_symbol) {}

/*!
* \brief Check the pipeline satisfies the following conditions:
Expand Down Expand Up @@ -1103,8 +1104,14 @@ class PipelineInjector : private StmtExprMutator {
Downcast<Array<Integer>>(op->annotations.at(attr::software_pipeline_stage));
auto pipeline_orders =
Downcast<Array<Integer>>(op->annotations.at(attr::software_pipeline_order));
CHECK_EQ(pipeline_stages.size(), original_order.size());
CHECK_EQ(pipeline_orders.size(), original_order.size());
CHECK_EQ(pipeline_stages.size(), original_order.size())
<< "PrimFunc " << global_symbol_ << " has original order "
<< original_order.Map([](const auto& block) { return block->name_hint; })
<< ", but pipeline annotation is " << pipeline_stages << " with different size";
CHECK_EQ(pipeline_orders.size(), original_order.size())
<< "PrimFunc " << global_symbol_ << " has original order "
<< original_order.Map([](const auto& block) { return block->name_hint; })
<< ", but pipeline annotation is " << pipeline_orders << " with different size";

std::unordered_set<int> pipeline_async_stages;
if (auto annot = op->annotations.Get(attr::software_pipeline_async_stages)) {
Expand Down Expand Up @@ -1205,6 +1212,7 @@ class PipelineInjector : private StmtExprMutator {
Map<Var, Buffer> buffer_data_to_buffer_;
std::unordered_map<const VarNode*, FragmentInfo> fragment_info_;
std::unordered_set<Buffer, ObjectPtrHash, ObjectPtrEqual> double_buffers;
Optional<String> global_symbol_;
};

} // namespace software_pipeline
Expand Down