[TIR] Use String instead of StringImm for AttrStmtNode::node #14491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tir::StringImm` can round-trip through TVMScript when used in a context that requires a PrimExpr, such as the arguments of a `tir::Call`. However, contexts that only require a `ObjectRef`, such as the `AttrStmtNode::node`, use the same TVMScript representation as `"string_value"`, but are parsed `tvm::String` instances. This commit updates `MakePackedAPI` to use `String` instead of `StringImm` in its default value for `AttrStmtNode::node`.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Contributor
Author
|
The test added by this PR depends on the #14488. Should re-run CI after that one lands. |
kparzysz-quic
approved these changes
Apr 11, 2023
Contributor
kparzysz-quic
left a comment
kparzysz-quic
left a comment
There was a problem hiding this comment.
LGTM. Is this the only place where this happens?
Contributor
Author
|
While it's possible that other cases may exist, they aren't part of the usual lowering flow. This was the only instance of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tir::StringImmcan round-trip through TVMScript when used in a context that requires a PrimExpr, such as the arguments of atir::Call. However, contexts that only require aObjectRef, such as theAttrStmtNode::node, use the same TVMScript representation as"string_value", but are parsedtvm::Stringinstances.This commit updates
MakePackedAPIto useStringinstead ofStringImmin its default value forAttrStmtNode::node.This is part of changes described in #14486, to improve round-trip failures that occur in lowering.