[TIR] Update SplitHostDevice to post-process with ConvertSSA #14496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
When passes create new PrimFuncs, such as when `tir.SplitHostDevice` separates out a `tir::Stmt` into an independent function, the parameters of these new function may alias existing variable definitions. While this is well-defined, because variable definitions are not shared across function boundaries, it can give false discrepancies from `tvm.ir.assert_structural_equal`. This commit implements `tvm::tir::transform::ConvertSSA`, which ensures unique variable declaration locations across an entire module.
Avoid duplicate variable defitions between the host and device PrimFunc.
Lunderberg
force-pushed
the
ssa_after_split_host_device
branch
from
0da86aa to
bb768b0
Compare
Contributor
Author
|
@tvm-bot rerun |
tqchen
approved these changes
Apr 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the same
tir::Varcould be defined both in the body of the host function and in a parameters of the device function. While this is legal, as TIR only requires SSA across eachPrimFunc, this does result in failure to round-trip through TVMScript, because the round-tripped TIR uses a newtir::Varin each instance. This PR adds aConvertSSA()transform that can apply to an entireIRModule, in addition to the existingConvertSSA(Stmt)utility.This is part of changes described in #14486, to improve round-trip failures that occur in lowering.