Skip to content

[Unity] Skip shape checking on transformed params #15736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 19, 2023
Merged

[Unity] Skip shape checking on transformed params #15736

merged 3 commits into from
Sep 19, 2023

Conversation

@vinx13
Copy link
Member

@vinx13 vinx13 commented Sep 13, 2023

@github-actions github-actions bot requested a review from masahi September 13, 2023 00:54
@vinx13
Copy link
Member Author

vinx13 commented Sep 14, 2023

seems we can't simply skip the weights. we need to check whether weights are dynamic, and only skip checking weights with static shape as for dynamic shapes we need to update shape heap

jwfromm
jwfromm approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@jwfromm jwfromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Wuwei!

@jwfromm jwfromm merged commit 25c6218 into apache:unity Sep 19, 2023
@jwfromm jwfromm mentioned this pull request Sep 20, 2023
Merged
@Lunderberg Lunderberg mentioned this pull request Jan 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jwfromm jwfromm jwfromm approved these changes

@masahi masahi Awaiting requested review from masahi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vinx13 @jwfromm