[Unity] Set CMAKE_CUDA_ARCHITECTURES default to native #16335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I like the change, and this makes sense to me. |
Contributor
|
Since #16302 passed CI, and is now merged in as a temporary fix, can this PR also revert the changes from it? |
vinx13
force-pushed
the
unity-cmake-native-cuda
branch
from
621fc09 to
47a3c9d
Compare
yongwww
approved these changes
Jan 9, 2024
Lunderberg
approved these changes
Jan 9, 2024
Contributor
Lunderberg
left a comment
Lunderberg
left a comment
There was a problem hiding this comment.
Thank you for the changes, and for handling the changes between TVM and the cutlass kernels!
vinx13
force-pushed
the
unity-cmake-native-cuda
branch
from
113f38d to
1d600da
Compare
Contributor
|
Late to the party but just wanted to say i love this change. Thanks Wuwei! |
Contributor
|
It looks like cmake's GPU detection isn't perfect (tested with cmake I don't have a good long-term solution for this issue, but a current workaround is to explicitly call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI images should also be updated to install cmake 3.24
cc @tqchen @junrushao @Lunderberg