[TIR] Allow sync threads inside condition #16345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinhongyii
approved these changes
Jan 4, 2024
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Jan 7, 2024
Originally, it is not allowed to sync threads inside a condition `while, if`. This PR introduces `tvm_thread_invariant` op to annotate the condition to be thread id invariant and get around the check.
junrushao
added a commit
to junrushao/tvm
that referenced
this pull request
Jan 15, 2024
PR apache#16345 introduced a TIR intrinsic `tvm_thread_invariant` as a no-op intrinsic that indicates that a condition is an invariant across threads. It is a necessary change to support MoE group GEMM operations. However, we noticed that the LLVM-ROCm backend has been broken since then because this no-op intrinsic hasn't been properly handled in this particular backend. This PR fixes this behavior by checking this no-op in the LLVM backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, it is not allowed to sync threads inside a condition
while, if.This PR introduces
tvm_thread_invariantop to annotate the condition to be thread id invariant and get around the check.