[Metal] Dispatch numerically stable tanh for metal #16438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
MasterJH5574
approved these changes
Jan 19, 2024
Member
Author
|
Observed the same issue on webgpu as well; updated to fix. |
This was referenced Jan 20, 2024
junrushao
pushed a commit
to mlc-ai/mlc-llm
that referenced
this pull request
Jan 21, 2024
This PR updates `debug_intermediate.py` that uses instrumenting to debug a compiled model library, adding some comments on the script and making it SLM-model compatible. To run: ``` python tests/legacy-python/dump_intermediate.py --model dist/phi-2-q4f16_1-MLC --model-lib-path dist/phi-2_q4f16_1-cuda.so ``` While we can use JIT to print intermediate values for debugging, as of now it only supports cpu. Some issues are platform-specific, and this script could still come in handy (e.g. helped solve apache/tvm#16438, #1638).
smickey040404
added a commit
to smickey040404/mlc-llm
that referenced
this pull request
Feb 11, 2025
This PR updates `debug_intermediate.py` that uses instrumenting to debug a compiled model library, adding some comments on the script and making it SLM-model compatible. To run: ``` python tests/legacy-python/dump_intermediate.py --model dist/phi-2-q4f16_1-MLC --model-lib-path dist/phi-2_q4f16_1-cuda.so ``` While we can use JIT to print intermediate values for debugging, as of now it only supports cpu. Some issues are platform-specific, and this script could still come in handy (e.g. helped solve apache/tvm#16438, mlc-ai/mlc-llm#1638).
tristankincaid
added a commit
to tristankincaid/mlc-llm
that referenced
this pull request
Feb 16, 2025
This PR updates `debug_intermediate.py` that uses instrumenting to debug a compiled model library, adding some comments on the script and making it SLM-model compatible. To run: ``` python tests/legacy-python/dump_intermediate.py --model dist/phi-2-q4f16_1-MLC --model-lib-path dist/phi-2_q4f16_1-cuda.so ``` While we can use JIT to print intermediate values for debugging, as of now it only supports cpu. Some issues are platform-specific, and this script could still come in handy (e.g. helped solve apache/tvm#16438, mlc-ai/mlc-llm#1638).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR,
tanh(x)returnsNaNon metal whenx > 45.0.Metal's built-in tanh is implemented as
(t - 1.0) / (t + 1.0), wheret = exp(2.0 * x). Hence for largex,tbecomesinf, causingtanh(x)to beNaN.A numerically stable
tanhis implemented forllvm, this PR lifts it tosrc/target/intrin_rule.ccand apply the same rule for metal as well.