[Transform] Improve symbolic variable handling in FuseOps #16450
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit,
FuseOpsandFuseOpsByPatternexposed a symbolic variable to the fused function if it was used within the fused function, but wasn't inferable from other parameter shapes. While this prevents undefined symbolic variables, it can cause issues for downstream use ofCodegenJSON, which requires all arguments to be tensors, or tuple of tensors.Frequently, all uses of a non-inferable symbolic shape occur within a symbolic expression that can be inferred. For example, a function that takes
arg: R.Tensor([N+1])and returnsR.add(arg, R.const(1))cannot inferN. However, all occurrences ofNoccur as part of the expressionN+1, and the value ofN+1can be inferred. Therefore, if we replaceN+1withM, the additionalShapeTupleargument isn't required.In addition, prior to this commit, the
CompositeFunctionAnnotatorvisited the body of functions without the parameters being considered in-scope. As a result,EraseToWellDefinedwould remove known shapes from the function body'sStructInfo.