[TIR] Require exactly same-dtype matching for Vulkan smem reuse #16515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the StorageRewrite pass which failed to avoid shared memory reuse of different dtypes for Vulkan. Since the Vulkan target information is required at the time of lowering, the pass `BindTarget` needs to apply before lowering, so that the functions have correct target information. Note that previously the pass checks `Target::Current`, while `tvm.build` does not set the current target. One regression test is added.
tqchen
approved these changes
Feb 3, 2024
This was referenced Feb 7, 2024
rickzx
added a commit
to mlc-ai/relax
that referenced
this pull request
Feb 7, 2024
Related to: apache/tvm#16515 WebGPU has the problem of shared memory reuse with different dtype as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the StorageRewrite pass which failed to avoid shared memory reuse of different dtypes for Vulkan.
Since the Vulkan target information is required at the time of lowering, the pass
BindTargetneeds to apply before lowering, so that the functions have correct target information. Note that previously the pass checksTarget::Current, whiletvm.builddoes not set the current target.One regression test is added.