[TIR] Fix get_block_access_region for let bindings #16553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 10, 2024 23:58
The current implementation of `block_access_region_detector` does not consider the let bindings inside the block. To be more specific: - The let bindings inside the block can be the index of buffer access indices - The let bindings var is defined inside the block, so the block annotation cannot use those vars. - We need to substitute the let bindings inside the block to the block annotation. This PR fixes this problem and can create legal IRs.
tqchen
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
block_access_region_detectordoes not consider the let bindings inside the block. To be more specific:This PR fixes this problem and can create legal IRs.