[Unity][Analysis] Include impure call in VerifyWellFormed errors #16585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, `VerifyWellFormed` would state that a dataflow block or pure function contained an impure call, but identifying which call was impure was left to the user. This commit updates `VerifyWellFormed` to show the impure `relax::Call` as part of the error message.
slyubomirsky
approved these changes
Feb 22, 2024
Contributor
slyubomirsky
left a comment
slyubomirsky
left a comment
There was a problem hiding this comment.
A very good UX improvement, thanks a ton.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit,
VerifyWellFormedwould state that a dataflow block or pure function contained an impure call, but identifying which call was impure was left to the user.This commit updates
VerifyWellFormedto show the impurerelax::Callas part of the error message.